Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm-optimizer): extract wasm optimizer from wasm builder #4127

Merged
merged 11 commits into from
Aug 15, 2024
Merged

feat(wasm-optimizer): extract wasm optimizer from wasm builder #4127

merged 11 commits into from
Aug 15, 2024

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Aug 8, 2024 •
edited
Loading

NOTE: as for #4095, this PR didn't add checks from wasm-proc to gbuild since the checks are for node but not programs

Resolves #4123
Resolves #4095
see also #3835 (comment)

  • extract wasm-optimizer from wasm-builder
  • use wasm-optimizer in wasm-builder
  • use wasm-optimizer in cargo-gbuild

@gear-tech/dev

@clearloop clearloop added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Aug 8, 2024
@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Aug 8, 2024
@breathx
Copy link
Member

breathx commented Aug 8, 2024

please fetch latest master once again @clearloop

@clearloop clearloop requested a review from ark0f August 9, 2024 07:47
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Aug 15, 2024
@breathx breathx merged commit 59f8dc2 into master Aug 15, 2024
11 checks passed
@breathx breathx deleted the cl/issue-4123 branch August 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ark0f ark0f ark0f approved these changes

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes
Projects
None yet
Milestone
No milestone
3 participants
@clearloop @breathx @ark0f